Fix | v1 - Deprecate Invalid Page Property #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new property to the abstract
Paginator
class:$this->currentPage
. This property should be used as a replacement for the$this->page
property especially when used inside of theisLastPage
method.I have deprecated the old
page
property andgetPage
method because they would often be one figure higher than they should be. The reason why is with the order of how iterators work in PHP.The old
page
property started at 1 on rewind so what happened was:$this->page = 1
isLastPage
is not called$this->page = 2
The new
currentPage
property is now being used internally in the code which starts at zero instead of one and all tests pass.