Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show embedded Entry Widget view in the example app #1135

Open
wants to merge 2 commits into
base: feature/entry-widget-and-secure-conversations-v2
Choose a base branch
from
Open

Show embedded Entry Widget view in the example app #1135

wants to merge 2 commits into from
+76 −6

Conversation

AndriiHorishniiMOC
Copy link
Contributor

@AndriiHorishniiMOC AndriiHorishniiMOC commented Oct 30, 2024 •
edited
Loading

Jira issue:
https://glia.atlassian.net/browse/MOB-3714

What was solved?
Add ability to show embedded Entry Widget view in the example app

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from Android SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

Screen_recording_20241030_111913.mp4

@AndriiHorishniiMOC AndriiHorishniiMOC requested a review from a team as a code owner October 30, 2024 05:50
@AndriiHorishniiMOC
Copy link
Contributor Author

I added changes:

  1. The Entry Widget add not in the bottom container to test its height changes.
  2. The container for the Entry Widget looks according to the design.
Screen_recording_20241030_111913.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavDo DavDo DavDo approved these changes

@andrews-moc andrews-moc andrews-moc approved these changes

@gugalo gugalo Awaiting requested review from gugalo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndriiHorishniiMOC @DavDo @andrews-moc