Mob 3730 file preview doesnt work in chat for messages with attachments #1134
+1,290
−1,360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue:
https://glia.atlassian.net/browse/MOB-3730
Important
Sorry for the big PR, I tried to split it into smaller commits 1 - rename, 2 - refactoring, 3 - unit tests(currently working on), but
refactoring
still is bigger than expected, but sometimes it is the only way to do refactorings.What was solved?
SendMessagePayload
local wrapper since we can get all the information from core sdksSendMessagePayload
Chat
logic to use local attachments withUri
for visitor-sent attachments instead of downloading and caching them locallyUnsent
message type because currently, we're adding all the visitor messages as a preview and then updating their status in chatTo align chat behavior with iOS
I will also add a video later to demonstrate these changes.
Release notes:
Additional info:
Screenshots: