set LLM limits via ENV #348
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakowicz
reviewed
Oct 1, 2025
Comment on lines
+34
to
+37
| // Set rate limits for the provider or use ENV variables if set | ||
| const limits = Number(requestsPerMinute) > 0 ? | ||
| { tokensPerMinute: Number(tokensPerMinute), requestsPerMinute: Number(requestsPerMinute) } : | ||
| PROVIDER_LIMITS[this.provider]; |
Owner
There was a problem hiding this comment.
Can we make this nullable by default?
Then:
- when
null- use default limits - when
0- turn off rate limits - when
>0- set custom rate limits.
This gives us the ability to turn off rate-limiting.
Contributor
Author
There was a problem hiding this comment.
sure. I'm not proficient in typescript so give me some time to learn how to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #310