Update rr-replay.py to work with rr 5.8.0 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the report and the fix! We could make it more general by using regex. Could you please rebase on top of master where I fixed the tests? |
Now it works with rr version 5.8.0
|
@sakhnik I rebased over master and used regex to make it more general. Tested with versions 5.7.0 and 5.8.0. Not sure if there was any other changes before those versions. |
|
Thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice that the
GdbStartRRwas not working, so I fixed it. But it appears it have stopped working just in the last version (rr-debugger/rr@07d2aeb), so I am not sure if you would like to break support from all previous versions to address this.I don't have time to make a more generalized fix, but here is with a have done.