Support older GDB versions which use python2.7 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tearandfix
force-pushed
the
older-gdb-python2-support
branch
from
2c55ddf
to
e9a79d6
Compare
|
Thanks for the PR. Could you please merge from devel or master (or rebase on top of one of them)? I want to run the tests. |
tearandfix
force-pushed
the
older-gdb-python2-support
branch
from
e9a79d6
to
fe75712
Compare
Rebased on top of master. |
|
I appreciate your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome project!
I tried using it for ESP32 debugging which uses its own gdb fork but it didn't work out of the box.
Apparently this gdb version uses python2.7 and complains about some python3 specific syntax.
This PR removes python3 specific code to make gdb_commands.py compatible with python2.7.
It woks fine with ESP32-S3 gdb:
I only tested it with ESP32-S3 and a native gdb 15.1 on arch linux.