Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Newページ仕上げ #84

Merged
merged 29 commits into from
Apr 15, 2024
Merged

Feat/Newページ仕上げ #84

merged 29 commits into from
Apr 15, 2024

Conversation

nakamuraitsuki
Copy link
Contributor

useStateとマークダウン関係のものが共存できなかったので切り分けました。

@nakamuraitsuki nakamuraitsuki linked an issue Apr 13, 2024 that may be closed by this pull request
@nakamuraitsuki nakamuraitsuki self-assigned this Apr 13, 2024
Copy link

cloudflare-workers-and-pages bot commented Apr 13, 2024

Deploying maximum-public-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 75bcb26
Status: ✅  Deploy successful!
Preview URL: https://bc9f8b08.maximum-public-website.pages.dev
Branch Preview URL: https://feat-news-page-view.maximum-public-website.pages.dev

View logs

@batora9
Copy link
Contributor

batora9 commented Apr 13, 2024

レスポンシブ対応おれがやるね

%1 Outdated Show resolved Hide resolved
src/app/news/[slug]/page.tsx Outdated Show resolved Hide resolved
src/components/news-page-list/news-list-view.tsx Outdated Show resolved Hide resolved
src/components/news-page-list/news-page-list.tsx Outdated Show resolved Hide resolved
Copy link
Member

@sor4chi sor4chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

お願いします

@nakamuraitsuki nakamuraitsuki requested a review from sor4chi April 13, 2024 12:36
src/app/news/[slug]/page.tsx Outdated Show resolved Hide resolved
src/components/news-page-list/news-page-list.module.scss Outdated Show resolved Hide resolved
src/components/news-page-list/news-page-list.module.scss Outdated Show resolved Hide resolved
src/app/news/page.tsx Outdated Show resolved Hide resolved
src/components/news-page-list/news-list-view.tsx Outdated Show resolved Hide resolved
src/components/news-page-list/news-page-list.module.scss Outdated Show resolved Hide resolved
src/app/news/[slug]/page.tsx Outdated Show resolved Hide resolved
@sor4chi
Copy link
Member

sor4chi commented Apr 14, 2024

開発が止まっているっぽいので自分がキャッチアップします、ごめんね @nakamuraitsuki 途中までありがとう!

@sor4chi sor4chi force-pushed the feat/news-page-view branch from 85e1a5c to 423bd1d Compare April 14, 2024 19:52
@sor4chi sor4chi requested review from a01sa01to and batora9 April 14, 2024 20:38
src/app/news/[slug]/page.tsx Outdated Show resolved Hide resolved
Copy link
Member

@a01sa01to a01sa01to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ終わったらテスト記事は消す?

@sor4chi
Copy link
Member

sor4chi commented Apr 15, 2024

これ終わったらテスト記事は消す?

@batora9

@batora9
Copy link
Contributor

batora9 commented Apr 15, 2024

@sor4chi test[2-9].mdを消しちゃってください!おねがいします

@sor4chi sor4chi requested review from a01sa01to and batora9 April 15, 2024 01:06
@batora9
Copy link
Contributor

batora9 commented Apr 15, 2024

そらちさんがapproveしないとmergeできなそう?
mergeまでしちゃってください!

@sor4chi sor4chi merged commit cf8afea into main Apr 15, 2024
2 checks passed
@sor4chi sor4chi deleted the feat/news-page-view branch April 15, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newsページを仕上げる
4 participants