Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dynamic hero image #71

Merged
merged 13 commits into from
Apr 10, 2024
Merged

feat: Dynamic hero image #71

merged 13 commits into from
Apr 10, 2024

Conversation

batora9
Copy link
Contributor

@batora9 batora9 commented Apr 9, 2024

hero画像にテキストを表示させたり、ぼかしをかけられるようにしてコンポーネントとして統一させました

@batora9 batora9 self-assigned this Apr 9, 2024
@batora9 batora9 linked an issue Apr 9, 2024 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Apr 9, 2024

Deploying maximum-public-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 04e2906
Status: ✅  Deploy successful!
Preview URL: https://0c7559e1.maximum-public-website.pages.dev
Branch Preview URL: https://feat-dynamic-hero-image.maximum-public-website.pages.dev

View logs

@batora9 batora9 requested a review from a01sa01to April 9, 2024 04:03
@sor4chi
Copy link
Member

sor4chi commented Apr 9, 2024

Screenshot 2024-04-09 at 14 06 45

Screen.Recording.2024-04-09.at.14.07.27.mov

高さが変わるのが気になるかも

@batora9
Copy link
Contributor Author

batora9 commented Apr 9, 2024

/aboutにはまだ実装せずに、/だけとりあえず実装しました。(/newsもまだmergeされていないためほかのページを一気にheroを実装するのは後にした方がいいのではと思いました)

@sor4chi
Copy link
Member

sor4chi commented Apr 9, 2024

高さの違い直せそう? @batora9

@batora9
Copy link
Contributor Author

batora9 commented Apr 9, 2024

@sor4chi それはHeroImageコンポーネントのことですか?
現aboutページのheroはあとで置き換えます

@sor4chi
Copy link
Member

sor4chi commented Apr 9, 2024

おけ!そういうことね!

@sor4chi
Copy link
Member

sor4chi commented Apr 9, 2024

@batora9 コンフリクトしてるっぽい

@batora9 batora9 merged commit 095e077 into main Apr 10, 2024
2 checks passed
@batora9 batora9 deleted the feat/dynamic-hero-image branch April 10, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic hero image
3 participants