Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: /newsのデザイン #69

Merged
merged 21 commits into from
Apr 9, 2024
Merged

feat: /newsのデザイン #69

merged 21 commits into from
Apr 9, 2024

Conversation

batora9
Copy link
Contributor

@batora9 batora9 commented Apr 6, 2024

ページネーションはできていません(あとでやる)
とりあえず一覧で並べるようにしました

@batora9 batora9 linked an issue Apr 6, 2024 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Apr 6, 2024

Deploying maximum-public-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 51ce71e
Status: ✅  Deploy successful!
Preview URL: https://fae64ed2.maximum-public-website.pages.dev
Branch Preview URL: https://feat-news-page-design.maximum-public-website.pages.dev

View logs

src/components/LinkCard/LinkCard.tsx Outdated Show resolved Hide resolved
src/app/news/page.module.scss Outdated Show resolved Hide resolved
src/components/LinkCard/LinkCard.tsx Outdated Show resolved Hide resolved
src/components/news-page-list/news-page-list.tsx Outdated Show resolved Hide resolved
src/app/news/page.module.scss Outdated Show resolved Hide resolved
src/components/LinkCard/LinkCard.tsx Outdated Show resolved Hide resolved
src/components/news-page-list/news-page-list.tsx Outdated Show resolved Hide resolved
@batora9 batora9 self-assigned this Apr 8, 2024
@batora9 batora9 requested review from a01sa01to and sor4chi April 8, 2024 08:00
Copy link
Member

@a01sa01to a01sa01to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

カラーコードの大文字小文字統一したい気もするけど Linter に任せればいい気もするので後でいいや

Copy link
Member

@sor4chi sor4chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

諸々突っ込みたいところあるけどリファクタリング後でできるのでとりあえずOK

@batora9 batora9 merged commit 2a704dc into main Apr 9, 2024
2 checks passed
@batora9 batora9 deleted the feat/news-page-design branch April 9, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

新着情報ページを仕上げる
3 participants