Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer作成 #54

Merged
merged 8 commits into from
Mar 27, 2024
Merged

Footer作成 #54

merged 8 commits into from
Mar 27, 2024

Conversation

shigekk
Copy link
Contributor

@shigekk shigekk commented Mar 22, 2024

No description provided.

@shigekk shigekk self-assigned this Mar 22, 2024
Copy link

cloudflare-workers-and-pages bot commented Mar 22, 2024

Deploying maximum-public-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 37cd8b1
Status: ✅  Deploy successful!
Preview URL: https://dcb93d68.maximum-public-website.pages.dev
Branch Preview URL: https://feat-footer-component.maximum-public-website.pages.dev

View logs

src/components/Footer/Footer.module.scss Outdated Show resolved Hide resolved
src/components/Footer/Footer.module.scss Outdated Show resolved Hide resolved
src/components/Footer/Footer.tsx Outdated Show resolved Hide resolved
@shigekk
Copy link
Contributor Author

shigekk commented Mar 22, 2024

ロゴの色が違うんですが
白いロゴはどこから持ってきたらいいですか
→解決しました

src/components/Footer/Footer.module.scss Outdated Show resolved Hide resolved
src/components/Footer/Footer.tsx Outdated Show resolved Hide resolved
Copy link
Member

@sor4chi sor4chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

お願いします

src/components/Footer/Footer.module.scss Outdated Show resolved Hide resolved
src/components/Footer/Footer.module.scss Outdated Show resolved Hide resolved
Copy link
Member

@sor4chi sor4chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これも追加で!

src/components/Footer/Footer.tsx Outdated Show resolved Hide resolved
src/components/Footer/Footer.tsx Outdated Show resolved Hide resolved
Copy link
Member

@a01sa01to a01sa01to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レスポンシブ対応ここではまだやらないんだっけ? やらないなら OK
(やる想定ならめっちゃ崩れてるのでダメ)

@sor4chi
Copy link
Member

sor4chi commented Mar 26, 2024

止まるので別でやりましょう
cc @yukikamome316

@batora9 batora9 merged commit 00dc6e4 into main Mar 27, 2024
2 checks passed
@batora9 batora9 deleted the feat/footer-component branch March 27, 2024 09:18
@shigekk shigekk restored the feat/footer-component branch March 27, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants