fix(window): make popup windows unmodifiable #2254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you! Sorry for the delay |
mikavilpas
added a commit
to mikavilpas/blink-ripgrep.nvim
that referenced
this pull request
Dec 19, 2025
**Issue:** Blink nightly has made the documentation window unmodifiable by default in saghen/blink.cmp#2254. This causes an error to be shown when blink-ripgrep tries to write to the documentation window. **Solution:** Temporarily make the documentation window modifiable while writing to it, and then revert that change. Closes #498
mikavilpas
added a commit
to mikavilpas/blink-ripgrep.nvim
that referenced
this pull request
Dec 19, 2025
**Issue:** Blink nightly has made the documentation window unmodifiable by default in saghen/blink.cmp#2254. This causes an error to be shown when blink-ripgrep tries to write to the documentation window. **Solution:** Temporarily make the documentation window modifiable while writing to it, and then revert that change. Closes #498
mikavilpas
added a commit
to mikavilpas/blink.cmp
that referenced
this pull request
Dec 21, 2025
**Issue:** The windows that blink.cmp creates were made unmodifiable in saghen#2254 This seems to cause issues when using a custom `draw()` function for rendering custom documentation in a plugin. I worked around it in mikavilpas/blink-ripgrep.nvim#499 by temporarily making the buffer modifiable. But it might still cause issues in other plugins that use custom draw functions. **Solution:** Upstream the fix to blink.cmp: temporarily make the buffer modifiable to avoid the issue.
saghen
pushed a commit
that referenced
this pull request
Dec 21, 2025
…2319) **Issue:** The windows that blink.cmp creates were made unmodifiable in #2254 This seems to cause issues when using a custom `draw()` function for rendering custom documentation in a plugin. I worked around it in mikavilpas/blink-ripgrep.nvim#499 by temporarily making the buffer modifiable. But it might still cause issues in other plugins that use custom draw functions. **Solution:** Upstream the fix to blink.cmp: temporarily make the buffer modifiable to avoid the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make windows generated by blink.cmp unmodifiable. It's useful for other plugins filter out the windows they don't want to render, e.g., winbar. Because the completion documentations actually modify the contents of the documentation window. Therefore, we also have to temporally change modifiable property during update. It's pretty much the same as #1889.