Rework the student list section of an assignment #8686
Conversation
- Moved the student filter under the “Student” title in the header - Switched global header actions to icon-only “forward” buttons after titles - Added skip toggles in the header for Assign/Collect (when peer grading is off) and Grade (when collection exists) - Skip flags for Assign/Collect are cleared/hidden when peer grading is enabled - Student list no longer renders its own header - The header in assignment.tsx now includes per-step actions/progress and filter Known flaw: Progress counts (especially Return) can feel unintuitive when toggling peer grading or skip states mid-stream.
|
@codex review this. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| function render_nbgrader() { | ||
| if (nbgrader_scores) { | ||
| return render_nbgrader_scores(); | ||
| } | ||
| if (!assignment.get("nbgrader") || assignment.get("skip_grading")) return; | ||
| if (!assignment.get("nbgrader")) return; | ||
|
|
||
| return render_run_nbgrader("Run nbgrader"); | ||
| } | ||
|
|
||
| function render_save_button() { | ||
| if (!is_editing) return; | ||
| return ( | ||
| <Button key="save" size={size} onClick={() => stop_editing()}> | ||
| Save | ||
| </Button> | ||
| ); | ||
| return render_nbgrader_scores(); |
There was a problem hiding this comment.
Assignments marked with skip_grading still render the nbgrader scores card and run button, because render_nbgrader now only checks assignment.get("nbgrader") before showing nbgrader UI. Previously the skip flag prevented any nbgrader actions from appearing. With this change, instructors who explicitly choose to skip grading will still see and can trigger nbgrader runs, which contradicts the “skip grading” workflow and can confuse users who expect all grading controls to be suppressed.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This was a very intentional change for all skip toggles: "skip" means that you are allowed to do the next step without completing the previous one, but you are still allowed to do the previous step if you want to. In particular, if there was already work done for the skipped column, it stays visible.
haraldschilly
added
the
PR-TODO-cocalc2
3 participants
The initial goal was to improve UI by making it more consistent in wording/behaviour/layout and less cluttered. Hopefully it was achieved and now we have:
Known problems:
Some screenshots, old on the left, new on the right, 200% browser zoom on a 27" monitor with 150% desktop zoom:
