test: enhancements #341
Merged
test: enhancements #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulRBerg
force-pushed
the
prb/enhancements
branch
from
97cf5e9 to
7965a7a
Compare
|
Yes - I will add a test for when the array count is zero in |
PaulRBerg
force-pushed
the
prb/enhancements
branch
from
57a04d7 to
630c579
Compare
|
@andreivladbrg I have just pushed a few new commits to:
Waiting for your review! |
|
Looks like it can be merged. |
|
Yeah, but before we merge, we should check what's going on with the e2e tests - I see that they fail with |
Looks like this, you probably had too many requests that day. |
PaulRBerg
force-pushed
the
prb/enhancements
branch
2 times, most recently
from
bc38cec to
35567f1
Compare
test: add "USDCLike" and "USDTLike" mockups test: fix input bounding in "createWithRange" tests test: fix input bounding in linear e2e tests test: rename "protocolContract" param to "sablierContract" test: rename "vars.amounts" to "vars.createAmounts"
PaulRBerg
force-pushed
the
prb/enhancements
branch
from
35567f1 to
da06e83
Compare
test: disable invariant call summaries test: lower invariant test depth and no. of runs
test: improve wording in test modifier
chore: delete Solhint rule "reason-string" chore: enable Solhint rule "named-parameters-mapping"
ci: explicitly set number of fuzz runs for unit tests test: delete fuzz runs and invariant depth from lite profile test: lower number of fuzz runs in default profile
PaulRBerg
force-pushed
the
prb/enhancements
branch
from
da06e83 to
faa76ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #317, #342, #346, and hopefully also #338.
Besides the above, this PR also includes a few other enhancements, such as the addition of an
expectEmitfunction in theBase_Testtest contract, which makes it possible to avoid writing the fullvm.expectEmit({ checkTopic1: true, ...syntax.