Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adapt to recent gRPC interface updates #84

Merged
merged 3 commits into from
Nov 26, 2024
Merged

fix: adapt to recent gRPC interface updates #84

merged 3 commits into from
Nov 26, 2024

Conversation

shikhar
Copy link
Member

@shikhar shikhar commented Nov 26, 2024

  • BasinMetadata renamed to BasinInfo
  • ListStream returns StreamInfos instead of just string names
  • ReconfigureBasinResponse includes BasinConfig

@shikhar shikhar requested a review from a team as a code owner November 26, 2024 04:02
@shikhar shikhar requested a review from vrongmeal November 26, 2024 15:45
vrongmeal
vrongmeal approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@vrongmeal vrongmeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

src/types.rs Outdated Show resolved Hide resolved
@shikhar shikhar merged commit 35cf031 into main Nov 26, 2024
3 checks passed
@shikhar shikhar deleted the sbnov25 branch November 26, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrongmeal vrongmeal vrongmeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shikhar @vrongmeal