Improve roborock update handling #1685
Conversation
There was a problem hiding this comment.
Looks very good to me, just a small remark about overwriting the send method.
Another point:
The order in which status calls are made could be important, so we schould make sure that the order in which we add the methods is the same order in which the calls are made.
Furthermore in some cases we might want to return multiple status containers from a single method call, see https://github.com/rytilahti/python-miio/pull/1614/files
rytilahti
force-pushed
the
feat/roborock/updatehelper
branch
from
5b5d16e
to
8c13902
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1685 +/- ##
=======================================
Coverage 81.74% 81.74%
=======================================
Files 191 191
Lines 17937 17937
Branches 3845 3845
=======================================
Hits 14662 14662
Misses 2987 2987
Partials 288 288 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Not all devices support all features, but we have currently no way of knowing what is supported. In order to allow embedding all supported information in the status container while avoiding making unnecessary I/O on subsequent queries, this introduces a small helper to do just that. The initial status() call will call all defined devicestatus-returning methods to find out which information is acquired correctly, and skip the unsupported queries in the following update cycles.
rytilahti
force-pushed
the
feat/roborock/updatehelper
branch
from
5ecf451
to
114f3e2
Compare
|
Hi @starkillerOG, I'll merge this now to unblock you. I changed the signature for embed to require a name (#1712), so that accessing the main status and other containers can be done in a nicer manner. Let me know if you encounter any issues! |
|
@rytilahti thank you very much, I have used this PR to update the roborock multi map PR here: #1614 |
Not all devices support all features, but we have currently no way of knowing what is supported. In order to allow embedding all supported information in the status container while avoiding making unnecessary I/O on subsequent queries, this introduces a small helper to do just that.
The initial status() call will call all defined devicestatus-returning methods to find out which information is acquired correctly, and skip the unsupported queries in the following update cycles.
This also embeds some more information (last clean details, mop dryer settings).
Ping @starkillerOG