Fix parameter type in notification callback and initialize Event after event loop initialization#64
Merged
rytilahti merged 3 commits intorytilahti:masterfrom Nov 28, 2022
Merged
Conversation
…ent after event loop has been initialized
rytilahti
reviewed
Oct 3, 2022
|
Hi there, I've tested the commit and it seems to work. |
Owner
|
Added the fallback just in case, and fixed the build. Thanks @krakowski! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bleak introduced a breaking change a few days ago changing the notification callback first parameter's type to
BleakGATTCharacteristic(wasintbefore). This lead to the following exception during runtime:This is now fixed by using
BleakGATTCharacteristic'shandleproperty instead.Also, this PR moves the initialization of the asyncio
Eventobject after the initialization of the event loop, because it seems thatasyncio.Event()creates a loop if none is present. The debug logs print outwhen the
Eventobject gets initialized before the loop. Putting it after the loop initializationasyncioprints the mentioned debug log only once and the exception is gone.Related Issues
Fixes #63
Fixes #56