Fix insertExpression throw #307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryansolid did you have time to take a look here? :) |
|
Understanding this, this is guarding specifically around trying to insert the parent in itself. Like the check is one level deep. I suppose that is all we need, because it is fragments that are breaking this. Actually no that isn't the case. This would break again as soon as the parent doesn't equal the inserted element. We could trace up but I think this needs some more though. Need to get back to the basis of why we grabbing the parent this way. I'm a bit foggy its been like 6 years since I wrote this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mends part one of solidjs/solid#2030 by selectively walking around that specific case
Tested and actually fixes the issue. Working test reproduction with yarn patch here:
yarn && yarn devbug-test.zip