add stripecheckout and multistripe auth support #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not really keen to add code specific to a non-official extension - it seems this is targeting a stripe checkout extension you are adding. I think you would be better making a distinct |
|
Hi Ryan, thanks for the advice! My extension multistripe has been approved and may take several days to show on the marketplace ;). I'll let you know once it is online! |
|
Hi Ryan, the MultiStripe is up now ;) https://tastyigniter.com/marketplace/item/philipxyc-multistripe |
|
Ok. I still think you should supply your own companion authorise extension to complement it. It doesn’t feel right to me to add support for it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.