Skip to content

Commit

Permalink
Restore AndroidEqualizer state after stop.
Browse files Browse the repository at this point in the history
  • Loading branch information
ryanheise committed Aug 31, 2021
1 parent 53e5948 commit 9858d85
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
1 change: 1 addition & 0 deletions just_audio/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## Next version

* Fix bug restoring AndroidEqualizer state after stop.
* Make exceptions implement Exception.
* Upgrade to ExoPlayer 2.13.3.

Expand Down
18 changes: 17 additions & 1 deletion just_audio/lib/just_audio.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3458,6 +3458,12 @@ class AndroidEqualizerBand {
}
}

/// Restores the gain after reactivating.
Future<void> _restore() async {
await (await _player._platform).androidEqualizerBandSetGain(
AndroidEqualizerBandSetGainRequest(bandIndex: index, gain: gain));
}

static AndroidEqualizerBand _fromMessage(
AudioPlayer player, AndroidEqualizerBandMessage message) =>
AndroidEqualizerBand._(
Expand Down Expand Up @@ -3487,6 +3493,13 @@ class AndroidEqualizerParameters {
required this.bands,
});

/// Restore platform state after reactivating.
Future<void> _restore() async {
for (var band in bands) {
await band._restore();
}
}

static AndroidEqualizerParameters _fromMessage(
AudioPlayer player, AndroidEqualizerParametersMessage message) =>
AndroidEqualizerParameters(
Expand All @@ -3512,7 +3525,10 @@ class AndroidEqualizer extends AudioEffect with AndroidAudioEffect {
@override
Future<void> _activate() async {
await super._activate();
if (_parametersCompleter.isCompleted) return;
if (_parametersCompleter.isCompleted) {
await (await parameters)._restore();
return;
}
final response = await (await _player!._platform)
.androidEqualizerGetParameters(AndroidEqualizerGetParametersRequest());
_parameters =
Expand Down

0 comments on commit 9858d85

Please sign in to comment.