This repository has been archived by the owner on Dec 12, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datamapper is not compatible to nested_form.
To have the
accepts_nested_attributes_for
in Datamapper you need use the gem :dm-accepts_nested_attributes
.But if you use it, nested_form is not compatible because 2 problems :
1. reflect_on_association
This method is not design in Datamapper. You need use the
klass.repository[association].target_model
instead.2. _destroy is not define
In this gem the attribute to mark a record destroy is
_delete
instead of_destroy
on ActiveRecord. And there are no method_destroy
or_delete
in the instance to check if this object can be delete or not in futur.This pull request help to work DataMapper and nested_form together. But actually, it's not compatible to ActiveRecord anymore. I can do the job to be compatible both. But I prefer start avoid it in first and do the job if needed.