Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @types/readable-stream to devDependencies Fixes #145 #147

Closed
wants to merge 1 commit into from

Conversation

guyellis
Copy link

@guyellis guyellis commented Nov 9, 2024

This should fix an upstream dependency issue that Tedious is having with TypeScript and the location of this dependency.

@rvagg
Copy link
Owner

rvagg commented Nov 9, 2024

Error: node_modules/@types/readable-stream/index.d.ts(419,11): error TS2420: Class 'Readable' incorrectly implements interface 'ReadableStream'.
  Types of property 'wrap' are incompatible.
    Type '(oldStream: Readable) => this' is not assignable to type '(oldStream: ReadableStream) => this'.
      Types of parameters 'oldStream' and 'oldStream' are incompatible.
        Type 'ReadableStream' is not assignable to type 'Readable'.
          Type 'ReadableStream' is missing the following properties from type 'Readable': readableAborted, readableDidRead, readableEncoding, readableEnded, and 28 more.

@guyellis guyellis closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants