Merge pull request #44 from yuri-kilochek/master

`shallowSlice` fix
rvagg · May 1, 2017 · 391fd88 · 391fd88
2 parents 199e5c1 + d4e4e1c
commit 391fd88
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/bl.js b/bl.js
@@ -200,14 +200,14 @@ BufferList.prototype.shallowSlice = function shallowSlice (start, end) {
     , endOffset = this._offset(end)
     , buffers = this._bufs.slice(startOffset[0], endOffset[0] + 1)
 
-  if (startOffset[1] != 0)
-    buffers[0] = buffers[0].slice(startOffset[1])
-
   if (endOffset[1] == 0)
     buffers.pop()
   else
     buffers[buffers.length-1] = buffers[buffers.length-1].slice(0, endOffset[1])
 
+  if (startOffset[1] != 0)
+    buffers[0] = buffers[0].slice(startOffset[1])
+
   return new BufferList(buffers)
 }
 

diff --git a/test/test.js b/test/test.js
@@ -560,9 +560,11 @@ tape('shallow slice across buffer boundaries', function (t) {
 })
 
 tape('shallow slice within single buffer', function (t) {
+  t.plan(2)
   var bl = new BufferList(['First', 'Second', 'Third'])
 
   t.equal(bl.shallowSlice(5, 10).toString(), 'Secon')
+  t.equal(bl.shallowSlice(7, 10).toString(), 'con')
   t.end()
 })