This repository was archived by the owner on Aug 25, 2025. It is now read-only.
Update Allocator trait implementation to compile on nightly#95
Open
rusty122 wants to merge 5 commits intorustwasm:masterfrom
Open
Update Allocator trait implementation to compile on nightly#95rusty122 wants to merge 5 commits intorustwasm:masterfrom
rusty122 wants to merge 5 commits intorustwasm:masterfrom
Conversation
Ran `cargo fmt` and renamed AllocErr to AllocError. The main rename was updating the Alloc trait (now the Allocator trait) and associated methods.
Includes more renaming missed in the previous commit. The allocate method needs to return a NonNull<[u8]>, so this commit updates bunch of callsites to handle the returned allocation correctly. Also cleaned up some alignment asserts for consistency (0 is not a power of 2, so some of the existing asserts were extraneous).
Author
|
cc @pepyakin @DrGoldfire @ZackPierce if anyone can review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #94
The wee_alloc build has been broken for a bit because the Rust
Allocator(previously calledAlloc) trait has changed interfaces. This PR updates the wee_alloc implementation to compile and run on nightly.There are probably some more cleanup possible and different testing possibilities with the new interface, but I tried to make the minimal changes necessary to fix the build and unblock other contributions.
Some functions and methods that are still experimental I implemented as helper-functions to avoid requiring nightly for the library, but left TODO comments to update once they stabilize.
Haven't made a ton of Rust contributions so let me know if I missed anything here!