-
Notifications
You must be signed in to change notification settings - Fork 370
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add information about unsoundness issue in anstream, found here: rust…
- Loading branch information
1 parent
1cd8580
commit 08da351
Showing
1 changed file
with
30 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
```toml | ||
[advisory] | ||
id = "RUSTSEC-0000-0000" | ||
package = "anstream" | ||
date = "2024-09-08" | ||
url = "https://github.com/rust-cli/anstyle/issues/156" | ||
informational = "unsound" | ||
|
||
[affected] | ||
functions = { "anstream::adapter::strip_str" = ["< 0.6.8"] } | ||
|
||
[versions] | ||
patched = [">= 0.6.8"] | ||
|
||
``` | ||
|
||
# Unsoundness in anstream | ||
|
||
When given a valid UTF8 string "ö\x1b😀", the function in | ||
crates/anstream/src/adapter/strip.rs will be confused. The UTF8 | ||
bytes are \xc3\xb6 then \x1b then \xf0\x9f\x98\x80. | ||
|
||
When looping over "non-printable bytes" \x1b\xf0 will be | ||
considered as some non-printable sequence. | ||
|
||
This will produce a broken str from the incorrectly segmented | ||
bytes via str::from_utf8_unchecked, and that should never happen. | ||
|
||
Full credit goes to @Ralith who reviewed this code and | ||
asked @burakemir to follow up. |