feat: Enhance CI workflow, logging, and optimized S3 bucket operations#20
Open
ZUOXIANGE wants to merge 11 commits intorustfs:mainfrom
Open
feat: Enhance CI workflow, logging, and optimized S3 bucket operations#20ZUOXIANGE wants to merge 11 commits intorustfs:mainfrom
ZUOXIANGE wants to merge 11 commits intorustfs:mainfrom
Conversation
…es returned by the server
Contributor
Author
|
Would you consider granting me maintainer access? I'd love to help keep this project running smoothly. @loverustfs |
Contributor
|
Ok |
There was a problem hiding this comment.
Pull request overview
This PR updates the demo’s CI/build policies and improves runtime observability and S3 bucket/file operations, while also modernizing the test stack.
Changes:
- Added source-generated logging for RustFSService operations and GlobalExceptionHandler.
- Optimized S3 bucket existence checks and bucket deletion (including objects) via
AmazonS3Util. - Updated CI workflow (lint + multi-OS build matrix) and migrated tests to xUnit v3 with cancellation token usage.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/RustFS.Demo.Tests/RustFSServiceTests.cs | Updates async lifetime + propagates xUnit v3 cancellation token into async calls. |
| tests/RustFS.Demo.Tests/RustFS.Demo.Tests.csproj | Migrates to xunit.v3 and suppresses CA1707 for underscore-style test names. |
| src/RustFS.Demo.Web/wwwroot/index.html | Improves client-side error handling by extracting server messages from error responses. |
| src/RustFS.Demo.Web/Services/RustFSServiceLogExtensions.cs | Introduces source-generated log extension methods for bucket/file operations. |
| src/RustFS.Demo.Web/Services/RustFSService.File.cs | Adds operation logging around presign/upload/get/delete/list file flows. |
| src/RustFS.Demo.Web/Services/RustFSService.Bucket.cs | Uses AmazonS3Util for bucket existence and deletes buckets with objects; adds logging. |
| src/RustFS.Demo.Web/Services/IRustFSService.cs | Removes trailing whitespace. |
| src/RustFS.Demo.Web/Program.cs | Simplifies S3 client creation overload usage and reorders usings. |
| src/RustFS.Demo.Web/Models/UploadResult.cs | Removes trailing whitespace. |
| src/RustFS.Demo.Web/Models/S3StorageOptions.cs | Removes trailing whitespace. |
| src/RustFS.Demo.Web/Infrastructure/GlobalExceptionHandler.cs | Switches to source-generated logging for exception logging. |
| src/RustFS.Demo.AppHost/Program.cs | Removes trailing whitespace. |
| Directory.Packages.props | Central package update for xUnit v3. |
| Directory.Build.props | Adds repo-wide build/analyzer settings (warnings as errors, analysis level, code style enforcement). |
| .github/workflows/ci.yml | Adds lint job and changes build/test execution strategy across OS matrix. |
| .github/dependabot.yml | Adds dependency update grouping for Microsoft/OpenTelemetry packages. |
| .editorconfig | Replaces prior config with a simplified, repo-wide formatting + C# style baseline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@loverustfs fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @loverustfs , could you please review this PR when you have a moment?