Add trait for linear allocation to enforce use of LinearAllocator at compile-time #188
Conversation
convert ndsp::Wave to be generic over any linearly-allocated type so that callers could use Vec etc. if they wanted.
ian-h-chamberlain
changed the title
This is stable in 1.78 but not in our pinned nightly, so just add the feature flag for now.
| @@ -23,6 +23,7 @@ | |||
| #![feature(try_trait_v2)] | |||
| #![feature(allocator_api)] | |||
| #![feature(new_uninit)] | |||
| #![feature(diagnostic_namespace)] | |||
There was a problem hiding this comment.
This feature is stable, there is no need to add it to the list.
There was a problem hiding this comment.
Unfortunately it's not stable yet in the pinned compiler version we have... I could raise the rust-version in our crate to 1.78 and bump the pinned nightly, if you think that's preferable?
Edit: actually, tried this but it won't work unless we update to a very recent nightly that contains rust-lang/rust#124649
My preference would probably be to leave it with #![feature] for now, but could still go either way.
There was a problem hiding this comment.
Ah right. I'm for the idea of "if we use an unstable feature, we should update the MSRV as soon as it is stabilised" since stability is the biggest reason I see why we should bump the MSRV.
Still, for such a small thing it isn't necessary. We can bump it later down the line whenever we see fit.
AsRef<T> accepts more types than Deref<Target = T>, so it makes sense to be compatible with more types if possible. Also make LinearAllocation an unsafe trait instead of sealing it, so that downstream users can implement it if they want.
Also convert
ndsp::Waveto be generic over any linearly-allocated type so that callers could use Vec etc. if they wanted.This will also be useful for
citro3d-rs, e.g. https://github.com/rust3ds/citro3d-rs/pull/42/files#r1477434491