Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support visuals with depth 32 on X11 #226

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Support visuals with depth 32 on X11 #226

merged 1 commit into from
Jun 22, 2024

Conversation

notgull
Copy link
Member

@notgull notgull commented Jun 22, 2024

This can lead to weird results in some cases, but it's better than crashing.
Once we have a better format API we can work around this.

ref rust-windowing/winit#3646

This can lead to weird results in some cases, but it's better than crashing.
Once we have a better format API we can work around this.

ref rust-windowing/winit#3646

Signed-off-by: John Nunley <[email protected]>
@notgull notgull requested a review from john01dav as a code owner June 22, 2024 16:25
@notgull notgull requested review from daxpedda, ids1024 and madsmtm and removed request for john01dav June 22, 2024 16:25
Copy link
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we don't want to return an error here instead because until we add a pixel format API its not actionable for users?

@notgull
Copy link
Member Author

notgull commented Jun 22, 2024

That is correct.

@notgull notgull merged commit 330804d into master Jun 22, 2024
38 checks passed
@notgull notgull deleted the notgull/trans branch June 22, 2024 20:48
@notgull notgull mentioned this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants