wgl: add support for pixel buffer surfaces #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SK83RJOSH
force-pushed
the
wgl-pbuffers
branch
from
838424a to
09a7611
Compare
kchibisov
requested changes
Sep 22, 2024
kchibisov
requested changes
Sep 22, 2024
kchibisov
requested changes
Sep 22, 2024
There was a problem hiding this comment.
Could you update doc here https://github.com/rust-windowing/glutin/blob/master/glutin/src/surface.rs#L522 with the pbuffer that could be present there?
Other than that looks good.
|
Done! Thank you for the thorough review, and my apologies for the sorry state of this initially. Have a great rest of your weekend. 🙂 |
SK83RJOSH
force-pushed
the
wgl-pbuffers
branch
from
0582c56 to
7a66063
Compare
kchibisov
reviewed
Sep 22, 2024
SK83RJOSH
force-pushed
the
wgl-pbuffers
branch
from
7a66063 to
29d0b70
Compare
kchibisov
reviewed
Sep 22, 2024
SK83RJOSH
force-pushed
the
wgl-pbuffers
branch
from
29d0b70 to
8925482
Compare
kchibisov
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif knowledge of this change could be valuable to usersCreated or updated an example program if it would help users understand this functionalityI didn't create an example, since this is standard functionality that was previously unexposed.