Implement priority hints for EGL #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valaphee
force-pushed
the
context-priority
branch
2 times, most recently
from
2625fe2 to
c63d6a8
Compare
kchibisov
requested changes
Sep 22, 2024
|
You need to add a |
I'm fine with adding such a check just for android target. |
kchibisov
force-pushed
the
context-priority
branch
from
c63d6a8 to
7e95d85
Compare
Add `GlContext::priority` and `ContextAttributesBuilder::with_priority` to get and set context priority respectively. Fixes rust-windowing#1694. Fixes rust-windowing#1645.
kchibisov
force-pushed
the
context-priority
branch
from
7e95d85 to
bca8a93
Compare
kchibisov
approved these changes
Nov 12, 2024
|
I've rabased it and added a getter, which could be used to log what level of priority context is using. |
|
Thanks. |
MarijnS95
reviewed
Nov 13, 2024
Comment on lines
+137
to
+141
| #[cfg(android_platform)] | ||
| let android = extensions.contains("EGL_ANDROID_front_buffer_auto_refresh") | ||
| && extensions.contains("EGL_ANDROID_create_native_client_buffer"); | ||
| #[cfg(not(android_platform))] | ||
| let android = false; |
There was a problem hiding this comment.
We wanted less #[cfg] conditional compilation, perhaps this could have been let android = cfg!(android_platform) && ...;?
There was a problem hiding this comment.
I thought about that, and decided to do it that way for now, since we already do things like that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1645
Fixes #1694
This PR adds a way to specify the priority for contexts. I mostly used the term hint, as its not guaranteed for various reasons that the context actually gets the priority.
Don't know if it makes sense to guarantee the priority. In Chromium it's also only used as a hint.
I also probably should extend the extension check as it is not correctly reported on Android.
https://github.com/chromium/chromium/blob/main/ui/gl/gl_display.cc#L814
Theoretically the extension also exists for GLX but Mesa for example doesn't support it.
CHANGELOG.mdif knowledge of this change could be valuable to users