egl/display: Pass *pointer to* output variable when querying DEVICE_EXT
#1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
All other calls to |
MarijnS95
force-pushed
the
egl-display-ptr
branch
from
d715310 to
4315fae
Compare
MarijnS95
commented
Sep 5, 2024
MarijnS95
force-pushed
the
egl-display-ptr
branch
3 times, most recently
from
83618d7 to
96fc48d
Compare
|
@kchibisov I also noticed that I think we need something like https://github.com/MarijnS95/glutin/compare/egl-display-attrib-value but I don't have any driver to test it on. |
…EXT` By casting a `null_mut()` ptr and passing it directly _by value_ to `QueryDisplayAttribEXT()`, the function ignores writing the output as it didn't receive an address (it received `NULL`) to write the device to. Instead we should take the _pointer address of this `null_mut()` pointer_ and provide that to the function instead so that it can _overwrite_ it with a pointer to the requested `eglDevice`. This is even more clear when allocating a `MaybeUninit` in which the pointer will be returned, which has a convenient `.as_mut_ptr()` member to pass its pointer value directly into `QueryDisplayAttribEXT()`.
MarijnS95
force-pushed
the
egl-display-ptr
branch
from
96fc48d to
326fd4f
Compare
kchibisov
approved these changes
Sep 5, 2024
|
Would you mind cutting a new release? Would make my life a little easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1695
By casting a
null_mut()ptr and passing it directly by value toQueryDisplayAttribEXT(), the function ignores writing the output as it didn't receive an address (it receivedNULL) to write the device to. Instead we should take the pointer address of thisnull_mut()pointer and provide that to the function instead so that it can overwrite it with a pointer to the requestedeglDevice.dbg!(display.device())toexamples/egl_device.rs. This returnsBadParameterbefore this patch, and the device afterwards.CHANGELOG.mdif knowledge of this change could be valuable to users