chore: remove deprecated feature cargo-clippy

[kchibisov]

--

@daxpedda we have the exact same one in winit if it matters. It's just to automatically throw errors when running clippy, so they are more likely to get fixed.

[daxpedda]

Usually done on the CLI level, but either way works for me.

Personally I find it quite annoying that I can't differentiate between errors and warnings when working with the code locally.

[kchibisov]

The thing is that it's only for clippy, it doesn't affect regular builds/check, etc. And clippy has no notion of errors.

Unless you always just run clippy instead of check.

[daxpedda]

And clippy has no notion of errors.

Not sure what you mean. It certainly has a concept called "error" and functionality behind it.

Unless you always just run clippy instead of check.

Yes, that's what I do to get actual Clippy warnings while I'm developing.

[kchibisov]

Yes, that's what I do to get actual Clippy warnings while I'm developing.

I guess it's just a workflow difference, because I tend to use check since it's far less noise and by the time I'm done with check I have very low amount of clippy issues. Doing clippy straight away is like really annoying.

given that you haven't complained about that in winit probably it was not really affecting you.

[daxpedda]

given that you haven't complained about that in winit probably it was not really affecting you.

It does, but I usually don't like to suggest things that change the workflow people are already accustomed to and works for them in a project that I don't solely own.
In any case, this is all very subjective and I can totally live with it if others would prefer to continue as-is!

Thanks for the input!