Conversation
lvoytek
approved these changes
Sep 10, 2025
Member
lvoytek
left a comment
lvoytek
left a comment
There was a problem hiding this comment.
Nice! The implementation here looks good to me overall.
Also for reference here is the version of tail being added to Ubuntu questing - https://github.com/uutils/coreutils/blob/main/src/uu/tail/src/tail.rs
Member
Author
|
@lvoytek thank you for your review! I think we can adapt this implementation and depend on it, but on the other hand, we don't need the full functionality of it, since we currently don't accept any CLI options for the tail command itself (it's already UPD: I've updated the tool to use the tail command from coreutils |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3