fix(tc): parse error message to correct kind

[ver-nyan]

Fixes the parse() error message for TC filters:

• "u32" & "matchall" for *_CLASSID
• "matchall" & "fq_codel" for DefaultNla

[gemini-code-assist]

Summary of Changes

Hello @ver-nyan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the clarity and accuracy of error messages within the Traffic Control (TC) filter parsing logic. Specifically, it rectifies misleading error contexts for CLASSID attributes in both u32 and matchall filter types, ensuring that diagnostic messages precisely reflect the component that failed to parse. This change enhances the debugging experience by providing more accurate information when parsing issues occur.

Highlights

• Error Message Correction: The pull request corrects an error message in src/tc/filters/cls_u32.rs related to parsing TCA_U32_CLASSID. The message was updated from indicating a failure to parse TCA_U32_UNSPEC to correctly state TCA_U32_CLASSID.
• Error Message Correction: Another error message correction was made in src/tc/filters/matchall.rs. The parsing failure message for TCA_MATCHALL_CLASSID was updated from TCA_MATCHALL_UNSPEC to TCA_MATCHALL_CLASSID.

Changelog

• src/tc/filters/cls_u32.rs
  • Corrected the error message for TCA_U32_CLASSID parsing from 'failed to parse TCA_U32_UNSPEC' to 'failed to parse TCA_U32_CLASSID'.
• src/tc/filters/matchall.rs
  • Corrected the error message for TCA_MATCHALL_CLASSID parsing from 'failed to parse TCA_MATCHALL_UNSPEC' to 'failed to parse TCA_MATCHALL_CLASSID'.

Activity

• No human activity has been recorded on this pull request since its creation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request corrects error messages in the parsing logic for u32 and matchall TC filters. Specifically, when parsing TCA_U32_CLASSID and TCA_MATCHALL_CLASSID, the error context incorrectly referred to ..._UNSPEC constants. The changes fix these error messages to correctly reference the ..._CLASSID constants, which will improve clarity when debugging parsing failures. The fixes are accurate, targeted, and improve the code's maintainability. I have no further suggestions.

[ver-nyan]

/gemini review

[gemini-code-assist]

Code Review

This pull request refines error messages across several TC filter and qdisc parsing functions. The changes update generic or incorrect error messages to be more specific to the context of the parsing failure (e.g., TCA_U32_UNSPEC to TCA_U32_CLASSID, u32 nla to matchall nla or fq_codel nla). These improvements enhance the debuggability and clarity of error reporting within the tc module. All comments are positive and highlight these beneficial changes.