Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ndk/media: Add bindings for AMediaCodecCryptoInfo, AMediaExtractor and AMediaDataSource #453

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ndk/media: Add bindings for AMediaCodecCryptoInfo, AMediaExtractor and AMediaDataSource #453

wants to merge 2 commits into from

Conversation

MarijnS95
Copy link
Member

Fixes #439

MarijnS95
MarijnS95 commented Dec 2, 2023
View reviewed changes
ndk/src/media/media_codec_crypto.rs
Comment on lines +32 to +38
#[doc(alias = "AMediaCodecCryptoInfo_new")]
pub fn new(
num_sub_samples: i32,
key: &[u8; 16],
iv: &[u8; 16],
mode: ffi::cryptoinfo_mode_t,
) -> Option<Self> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API/function isn't really done yet, I'll look for some testing material before merging this.

MarijnS95
MarijnS95 commented Dec 2, 2023
View reviewed changes
ndk/src/media/media_codec_crypto.rs
Comment on lines +103 to +105
/// one of AMEDIACODECRYPTOINFO_MODE_CLEAR or AMEDIACODECRYPTOINFO_MODE_AES_CTR.
#[doc(alias = "AMediaCodecCryptoInfo_getMode")]
pub fn mode(&self) -> ffi::cryptoinfo_mode_t {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs to be wrapped in an enum.

@MarijnS95 MarijnS95 mentioned this pull request Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencercw spencercw spencercw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AMediaExtractor and MediaCodec
2 participants
@MarijnS95 @spencercw