Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: rust-toolchain + profile in settings #4040

Merged
merged 1 commit into from
Oct 3, 2024
Merged

tests: rust-toolchain + profile in settings #4040

merged 1 commit into from
Oct 3, 2024

Conversation

lucacasonato
Copy link
Contributor

@lucacasonato lucacasonato commented Oct 2, 2024 •
edited by rami3l
Loading

This is a regression test for #3805.
This issue has seemingly been fixed on master already, and just needs to be
released.

Closes #3805.

@lucacasonato lucacasonato mentioned this pull request Oct 2, 2024
Closed
2 tasks
rami3l
rami3l approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks a bunch for your investigation!

@rami3l rami3l added this pull request to the merge queue Oct 3, 2024
@rami3l rami3l removed this pull request from the merge queue due to a manual request Oct 3, 2024
@djc djc added this pull request to the merge queue Oct 3, 2024
Merged via the queue into rust-lang:master with commit e774ac0 Oct 3, 2024
27 checks passed
@lucacasonato lucacasonato deleted the test branch October 3, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rami3l rami3l rami3l approved these changes

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rustup should use the configured profile as fallback when the key is not present in rust-toolchain.toml
3 participants
@lucacasonato @djc @rami3l