Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automatic self updates in CI environments #3907

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

djc
Copy link
Contributor

@djc djc commented Jun 25, 2024

Fixes #2886, fixes #3824.

@djc djc requested a review from rami3l June 25, 2024 08:38
src/config.rs Show resolved Hide resolved
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, as long as the CI is doing well...

@djc djc force-pushed the ci-no-self-update branch from 250f1fb to c154c8d Compare June 25, 2024 09:13
src/config.rs Outdated Show resolved Hide resolved
@djc djc force-pushed the ci-no-self-update branch from c154c8d to af99bc3 Compare June 25, 2024 09:35
@djc djc added this pull request to the merge queue Jun 25, 2024
@smoelius
Copy link
Contributor

FWIW, I think this is a really good idea. Thank you!

Merged via the queue into master with commit d4bbf6c Jun 25, 2024
27 checks passed
@djc djc deleted the ci-no-self-update branch June 25, 2024 10:24
@hoodmane
Copy link

I see that this fixes the problem but rustup hasn't had a release in 9 months. Could rustup make a release with this commit?

@rami3l
Copy link
Member

rami3l commented Jan 16, 2025

I see that this fixes the problem but rustup hasn't had a release in 9 months. Could rustup make a release with this commit?

@hoodmane We are currently in the middle of releasing v1.28.0 (#3998, https://internals.rust-lang.org/t/seeking-beta-testers-for-rustup-v1-28-0). For the moment being we are actively collecting feedback on our beta release. Thank you for your patience :)

@hoodmane
Copy link

How do I install rustup beta?

@hoodmane
Copy link

I guess I should read your link and I'd find out.

@hoodmane
Copy link

Thanks @rami3l!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants