reuse rewrite_static when formatting foreign static items
#6268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes 6267 The `ForeignItemKind::Static(_)` match arm in the `ast::ForeignItem` `Rewrite` impl duplicated some of the logic already implemented in `rewrite_static`, so reusing it helps centralize the logic. The other benefit to using `rewrite_static` is that it already supports rewriting the rhs of a static assignment.
ytmimi
commented
Aug 4, 2024
Comment on lines
-3403
to
-3404
| // FIXME(#21): we're dropping potential comments in between the | ||
| // function kw here. |
There was a problem hiding this comment.
To be honest I wasn't sure if this FIXME comment was misplaced or not. Would it be better to move this to the ast::ForeignItemKind::Fn match arm above?
|
@calebcartwright friendly ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6267
The
ForeignItemKind::Static(_)match arm in theast::ForeignItemRewriteimpl duplicated some of the logic already implemented inrewrite_static, so reusing it helps centralize the logic.The other benefit to using
rewrite_staticis that it already supports rewriting the rhs of a static assignment.