-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save linkcheck cache always #2030
Conversation
d97f06e
to
ca98813
Compare
Sorry, due to me messing up a git operation, we sadly had to force-push the whole commit history of rustc-dev-guide :( If you'd like to update this pull request, you will have to rebase it in a special way onto the new commit history (the new
More context can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused about what this change is accomplishing. Wouldn't making the cron job run every other day accomplish exactly the same thing?
Never mind, I just realized that the difference is that the cache will allow us to check new links without rechecking old links. Not sure why I didn't think of that 😅 |
Yeah, the main goal of the cache expiration is to at least partially reuse some of the GH links from the cache as one can't check all of them unless the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Thanks for the fix and the CI fix you landed just after my change! |
This PR always stores the linkcheck cache when being run as part of the scheduled CI job. Note the normal PRs ignore the cache and check only the modified files. I also extended the cache expiration time so that the Nighly job can face the congressional limit from Github.com (
"Server returned 429 Too Many Requests"
).Hopefully, it's a viable solution.
@camelid