Fix ICE on empty file with -Zquery-dep-graph#153210
Open
Delta17920 wants to merge 1 commit intorust-lang:mainfrom
Open
Fix ICE on empty file with -Zquery-dep-graph#153210Delta17920 wants to merge 1 commit intorust-lang:mainfrom
Delta17920 wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @jdonszelmann. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 28, 2026
…jdonszelmann Fix ICE on empty file with -Zquery-dep-graph added a guard in `DepGraph::register_dep_node_debug_str` so it early-returns when `self.data` is still `None`. this happens for the first few dep-nodes in an empty crate with `-Z query-dep-graph`, which caused the previous `unwrap()` panic. fixes rust-lang#153199
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a guard in
DepGraph::register_dep_node_debug_strso it early-returnswhen
self.datais stillNone. this happens for the first few dep-nodesin an empty crate with
-Z query-dep-graph, which caused the previousunwrap()panic.fixes #153199