Rollup of 3 pull requests #150500
Merged
Rollup of 3 pull requests #150500
+93
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dtolnay Implement `TryFrom<char>` for `usize`. Feature gate: `usize_try_from_char`. This PR implements `TryFrom<char>` for `usize`. `usize` is currently the only, unsigned, integral type to not implement `TryFrom<char>`. Technically, this conversion is trivial and can already be expressed with some indirection. I think it useful to be able to describe this set of types with this interface.
…pratt Mark set_times as unavailable for RTEMS target This PR just updates one of the config switches to exclude `utimesat` for the RTEMS target. This currently creates undefined reference errors when building the target. With this fix applied it also needs a fix in libc (see rust-lang/libc#4875) which will hopefully be available in release 0.2.179.
mir_build: Remove several remnants of `#![feature(inline_const_pat)]`
This PR cleans up some THIR-related code that was only needed for inline `const { .. }` blocks in patterns. The `inline_const_pat` feature was removed in rust-lang#138492 due to implementation concerns.
I considered retaining the code for preserving `ExpandedConstant` for range endpoints, but ultimately decided to remove that too, because I found it very awkward to document an edge case that is currently not needed by any subsequent code.
With this PR, `is_const_pat_that_looks_like_binding` is the only function that meaningfully consumes `thir::PatKind::ExpandedConst`.
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ rollup=never p=3 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: d874dce125 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing d874dce (parent) -> d465f99 (this PR) Test differencesShow 24 test diffs24 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard d465f990431b951f5b2d69aa499606db4b3ea359 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (d465f99): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary 2.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 482.826s -> 482.641s (-0.04%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
TryFrom<char>forusize. #146792 (ImplementTryFrom<char>forusize.)#![feature(inline_const_pat)]#150498 (mir_build: Remove several remnants of#![feature(inline_const_pat)])r? @ghost
@rustbot modify labels: rollup
Create a similar rollup