cleanup: move c-variadic arguments handling into compute_inputs_and_output #150454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @petrochenkov. Use |
oli-obk
requested changes
Dec 28, 2025
|
|
||
| let inputs = sig.inputs(); | ||
| let va_list_and_output = | ||
| iter::once(va_list_ty).chain(iter::once(sig.output().skip_binder())); |
Contributor
There was a problem hiding this comment.
Suggested change
| iter::once(va_list_ty).chain(iter::once(sig.output().skip_binder())); | |
| [va_list_ty, sig.output().skip_binder()]; |
| iter::once(va_list_ty).chain(iter::once(sig.output().skip_binder())); | ||
|
|
||
| // The signature needs to follow the order [input_tys, va_list_ty, output_ty] | ||
| return inputs.map_bound(|input| { |
Contributor
There was a problem hiding this comment.
Maybe use inputs_and_output and avoid the skip_binder on the output by doing everything inside the map_bound closure
rustbot
added
S-waiting-on-author
Contributor
|
r? oli-obk |
rust-cloud-vms
bot
force-pushed
the
move_variadic
branch
from
5cf029e to
91b1fa1
Compare
tiif
added
S-waiting-on-review
rust-cloud-vms
bot
force-pushed
the
move_variadic
branch
from
91b1fa1 to
791fa37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
unnormalized_input_tysneeds to be mutable because the c_variadic arguments are added tounnormalized_input_tysoutside ofcompute_inputs_and_output. This could have been done together incompute_inputs_and_output.