Update offload test and verify that tgt_(un)register_lib have the right type #150426
+40
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 29, 2025
add has_offload/needs-offload to the test infra unblocks: rust-lang#150426 Mostly copied from rust-lang#131044 lmk if some of these changes should land separately? r? jieyouxu
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Dec 29, 2025
add has_offload/needs-offload to the test infra unblocks: rust-lang#150426 Mostly copied from rust-lang#131044 lmk if some of these changes should land separately? r? jieyouxu
rust-timer
added a commit
that referenced
this pull request
Dec 29, 2025
Member
Author
|
@bors2 try aarch64-gnu-llvm-20-1 |
|
Unknown argument "aarch64-gnu-llvm-20-1". Run |
ZuseZ4
force-pushed
the
offload-register-lib
branch
from
2341687 to
ef942ba
Compare
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
removed
the
S-waiting-on-author
ZuseZ4
force-pushed
the
offload-register-lib
branch
from
ef942ba to
dbd1f05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, we weren't running offload tests when Enzyme wasn't built. Time to fix that.
Also adds a test mode which generates the host IR, but does not expect device IR/artifacts. This way, we don't have to handle artifacts and paths in our tests.
Also removes some outdated documentation.
cc @kevinsala, @Sa4dUs
closes: #150415
blocked onneeds-offloadinfrastructure landing in #150427