Move struct placeholder pt2

[Jamesbarford]

r? ghost

[lcnr]

there are currently a bunch of spurious edits + outdated formatting things here 🤔

[Jamesbarford]

Woops, yes, I'm sorting things out bit by bit. I'll squash all the commits when I'm done and remove the odd edits and commented out code.

[Jamesbarford]

I'm getting the following error and I'm not too sure why as I'm using #[derive_where(HashStable_NoContext)];

error[E0599]: the method `hash_stable` exists for reference `&binder::BoundRegion<I>`, but its trait bounds were not satisfied
    --> compiler/rustc_type_ir/src/region_kind.rs:228:19
     |
 228 |                 r.hash_stable(hcx, hasher);
     |                   ^^^^^^^^^^^ method cannot be called on `&binder::BoundRegion<I>` due to unsatisfied trait bounds
     |
    ::: compiler/rustc_type_ir/src/binder.rs:1014:1
     |
1014 | pub enum BoundRegionKind<I: Interner> {
     | ------------------------------------- doesn't satisfy `BoundRegionKind<I>: HashStable<_>`
...
1083 | pub struct BoundRegion<I: Interner> {
     | ----------------------------------- doesn't satisfy `binder::BoundRegion<I>: HashStable<_>`
     |
     = note: trait bound `BoundRegionKind<I>: HashStable<_>` was not satisfied
     = note: the following trait bounds were not satisfied:
             `binder::BoundRegion<I>: HashStable<_>`
             which is required by `&binder::BoundRegion<I>: HashStable<_>`
note: the trait `HashStable` must be implemented
    --> /rust/compiler/rustc_data_structures/src/stable_hasher.rs:44:1
     |
  44 | pub trait HashStable<CTX> {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0599]: the method `hash_stable` exists for reference `&binder::Placeholder<I, binder::BoundRegion<I>>`, but its trait bounds were not satisfied
    --> compiler/rustc_type_ir/src/region_kind.rs:237:19
     |
 237 |                 r.hash_stable(hcx, hasher);
     |                   ^^^^^^^^^^^ method cannot be called on `&binder::Placeholder<I, binder::BoundRegion<I>>` due to unsatisfied trait bounds
     |
    ::: compiler/rustc_type_ir/src/binder.rs:969:1
     |
 969 | pub struct Placeholder<I: Interner, T> {
     | -------------------------------------- doesn't satisfy `_: HashStable<_>`
...
1083 | pub struct BoundRegion<I: Interner> {
     | ----------------------------------- doesn't satisfy `binder::BoundRegion<I>: HashStable<_>`
     |
     = note: trait bound `binder::BoundRegion<I>: HashStable<_>` was not satisfied
     = note: the following trait bounds were not satisfied:
             `binder::Placeholder<I, binder::BoundRegion<I>>: HashStable<_>`
             which is required by `&binder::Placeholder<I, binder::BoundRegion<I>>: HashStable<_>`
note: the trait `HashStable` must be implemented
    --> /rust/compiler/rustc_data_structures/src/stable_hasher.rs:44:1
     |
  44 | pub trait HashStable<CTX> {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^

[rust-log-analyzer]

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling fallible-iterator v0.3.0
[RUSTC-TIMING] libloading test:false 0.178
[RUSTC-TIMING] fallible_iterator test:false 0.250
   Compiling gimli v0.31.1
error[E0599]: the method `hash_stable` exists for reference `&binder::BoundRegion<I>`, but its trait bounds were not satisfied
    --> compiler/rustc_type_ir/src/region_kind.rs:228:19
     |
 228 |                 r.hash_stable(hcx, hasher);
     |                   ^^^^^^^^^^^ method cannot be called on `&binder::BoundRegion<I>` due to unsatisfied trait bounds
     |
    ::: compiler/rustc_type_ir/src/binder.rs:1014:1
     |
1014 | pub enum BoundRegionKind<I: Interner> {
     | ------------------------------------- doesn't satisfy `BoundRegionKind<I>: HashStable<_>`
...
1083 | pub struct BoundRegion<I: Interner> {
     | ----------------------------------- doesn't satisfy `binder::BoundRegion<I>: HashStable<_>`
     |
     = note: trait bound `BoundRegionKind<I>: HashStable<_>` was not satisfied
     = note: the following trait bounds were not satisfied:
             `binder::BoundRegion<I>: HashStable<_>`
             which is required by `&binder::BoundRegion<I>: HashStable<_>`
note: the trait `HashStable` must be implemented
    --> /checkout/compiler/rustc_data_structures/src/stable_hasher.rs:44:1
     |
  44 | pub trait HashStable<CTX> {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0599]: the method `hash_stable` exists for reference `&binder::Placeholder<I, binder::BoundRegion<I>>`, but its trait bounds were not satisfied
    --> compiler/rustc_type_ir/src/region_kind.rs:237:19
     |
 237 |                 r.hash_stable(hcx, hasher);
     |                   ^^^^^^^^^^^ method cannot be called on `&binder::Placeholder<I, binder::BoundRegion<I>>` due to unsatisfied trait bounds
     |
    ::: compiler/rustc_type_ir/src/binder.rs:969:1
     |
 969 | pub struct Placeholder<I: Interner, T> {
     | -------------------------------------- doesn't satisfy `_: HashStable<_>`
...
1083 | pub struct BoundRegion<I: Interner> {
     | ----------------------------------- doesn't satisfy `binder::BoundRegion<I>: HashStable<_>`
     |
     = note: trait bound `binder::BoundRegion<I>: HashStable<_>` was not satisfied
     = note: the following trait bounds were not satisfied:
             `binder::Placeholder<I, binder::BoundRegion<I>>: HashStable<_>`
             which is required by `&binder::Placeholder<I, binder::BoundRegion<I>>: HashStable<_>`
note: the trait `HashStable` must be implemented
    --> /checkout/compiler/rustc_data_structures/src/stable_hasher.rs:44:1
     |
  44 | pub trait HashStable<CTX> {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^