Skip to content

feat: add from_fn_ptr to Waker and LocalWaker #146057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add from_fn_ptr to Waker and LocalWaker #146057

wants to merge 1 commit into from
+44 −0

Conversation

Ddystopia
Copy link
Contributor

@Ddystopia Ddystopia commented Aug 31, 2025 •
edited
Loading

Closes: #146055

@rustbot
Copy link
Collaborator

rustbot commented Aug 31, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 31, 2025
@xizheyin
Copy link
Member

Thanks for the PR. Using Closes #146055 in the PR description can close the issue when this PR is merged.

@jieyouxu
Copy link
Member

jieyouxu commented Sep 1, 2025

This may need an API Change Proposal instead of a r-l/r issue.
r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 1, 2025
@rustbot rustbot assigned dtolnay and unassigned scottmcm Sep 1, 2025
@Ddystopia Ddystopia mentioned this pull request Sep 1, 2025
Open
@cyrgani cyrgani added the S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. label Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dtolnay dtolnay

Labels
S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Waker::from_fn_ptr
7 participants
@Ddystopia @rustbot @xizheyin @jieyouxu @dtolnay @scottmcm @cyrgani