Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix malformed error annotations in a UI test #136403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmease
Copy link
Member

@fmease fmease commented Feb 1, 2025

The compiletest DSL still features a historical remnant from the time when its directives were merely prefixed with // instead of //@ when unknown directive names weren't rejected since they could just as well be part of prose:

As an "optimization", it stops looking for directives once it stumbles upon a line which starts with either fn or mod. This allowed a malformed error annotation of the form //@[…]~^^^ to go undetected & unexercised (as it's placed below fn main() {).

Obviously a character other than @ would've mangled the error annotation, too (but it might've caught the reviewer's eye). I specifically found this file because I ran rg '^(fn|mod)[\s\S]*?//@' tests/ui --multiline -trust to check how footgun-y that "special feature" of compiletest is.

@rustbot
Copy link
Collaborator

rustbot commented Feb 1, 2025

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 1, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Feb 1, 2025

r? @oli-obk @bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 1, 2025

📌 Commit 43b729d has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants