make UI tests that use --test work on panic=abort targets
#135823
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
rustbot
added
S-waiting-on-review
jieyouxu
approved these changes
Jan 21, 2025
|
r? jieyouxu |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bjorn3
reviewed
Jan 21, 2025
| //@ [can_unwind] needs-unwind | ||
| // | ||
| //@ revisions: cannot_unwind | ||
| //@ [cannot_unwind] compile-flags: --test -Zpanic_abort_tests |
There was a problem hiding this comment.
I think -Zpanic-abort-tests does nothing for -Cpanic=unwind so enabling it unconditionally should be fine.
There was a problem hiding this comment.
indeed, that works. updated the PR
|
@bors r- (one nit) |
bors
added
S-waiting-on-author
by adding `-Zpanic_abort_test`, which is a no-op on panic=unwind targets fixes rust-lang#135819
|
simplified the directives as per the inline suggestion |
|
Thanks! |
bors
added
S-waiting-on-bors
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Jan 22, 2025
make UI tests that use `--test` work on panic=abort targets By passing `-Zpanic_abort_test`. fixes rust-lang#135819
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 22, 2025
Rollup of 8 pull requests Successful merges: - rust-lang#135779 (CI: free disk on linux arm runner) - rust-lang#135794 (Detect missing fields with default values and suggest `..`) - rust-lang#135814 (ci: use ghcr buildkit image) - rust-lang#135818 (tests: Port `translation` to rmake.rs) - rust-lang#135823 (make UI tests that use `--test` work on panic=abort targets) - rust-lang#135837 (Remove test panic from File::open) - rust-lang#135852 (Add `AsyncFn*` to `core` prelude) - rust-lang#135856 (Library: Finalize dyn compatibility renaming) r? `@ghost` `@rustbot` modify labels: rollup
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Jan 22, 2025
make UI tests that use `--test` work on panic=abort targets By passing `-Zpanic_abort_test`. fixes rust-lang#135819
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By passing
-Zpanic_abort_test.fixes #135819