Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Python formatting check in tidy on CI #134964

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Dec 31, 2024

I don't think that there's a reason why we should ignore Python formatting on CI, when we already check Python lints and C++ formatting.

r? @onur-ozkan

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 31, 2024
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Waiting for CI.

@onur-ozkan
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 31, 2024

📌 Commit 787c2a2 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2024
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Dec 31, 2024
Print how to rebless Python formatting in tidy

Suggested [here](rust-lang#134964 (comment)).

r? `@Noratrieb`
tgross35 added a commit to tgross35/rust that referenced this pull request Dec 31, 2024
Print how to rebless Python formatting in tidy

Suggested [here](rust-lang#134964 (comment)).

r? ``@Noratrieb``
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 1, 2025
Rollup merge of rust-lang#134968 - Kobzol:tidy-bless-log, r=Noratrieb

Print how to rebless Python formatting in tidy

Suggested [here](rust-lang#134964 (comment)).

r? ``@Noratrieb``
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 1, 2025
Run Python formatting check in tidy on CI

I don't think that there's a reason why we should ignore Python formatting on CI, when we already check Python lints and C++ formatting.

r? `@onur-ozkan`
@bors
Copy link
Contributor

bors commented Jan 1, 2025

⌛ Testing commit 787c2a2 with merge 5190fd3...

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
test [mir-opt] tests/mir-opt/unreachable_enum_branching.rs ... ok

failures:

---- [mir-opt] tests/mir-opt/strip_debuginfo.rs#ALL stdout ----
thread '[mir-opt] tests/mir-opt/strip_debuginfo.rs#ALL' panicked at src/tools/compiletest/src/runtest.rs:213:30:
called `Result::unwrap()` on an `Err` value: Os { code: 17, kind: AlreadyExists, message: "File exists" }


failures:
    [mir-opt] tests/mir-opt/strip_debuginfo.rs#ALL

@bors
Copy link
Contributor

bors commented Jan 1, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 1, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented Jan 1, 2025

Looks spurious, or at least definitely unrelated to this PR.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2025
@bors
Copy link
Contributor

bors commented Jan 1, 2025

⌛ Testing commit 787c2a2 with merge 372442f...

@bors
Copy link
Contributor

bors commented Jan 1, 2025

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing 372442f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 1, 2025
@bors bors merged commit 372442f into rust-lang:master Jan 1, 2025
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Jan 1, 2025
@Kobzol Kobzol deleted the tidy-full-check branch January 1, 2025 19:53
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (372442f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 12.6%, secondary 2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
12.6% [1.7%, 28.3%] 15
Regressions ❌
(secondary)
2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 12.6% [1.7%, 28.3%] 15

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 760.671s -> 762.936s (0.30%)
Artifact size: 325.55 MiB -> 325.53 MiB (-0.01%)

@Kobzol
Copy link
Contributor Author

Kobzol commented Jan 1, 2025

Well, that was a particularly nasty walltime spike on html5ever..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants