-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Python formatting check in tidy on CI #134964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Waiting for CI.
@bors r+ |
Print how to rebless Python formatting in tidy Suggested [here](rust-lang#134964 (comment)). r? `@Noratrieb`
Print how to rebless Python formatting in tidy Suggested [here](rust-lang#134964 (comment)). r? ``@Noratrieb``
Rollup merge of rust-lang#134968 - Kobzol:tidy-bless-log, r=Noratrieb Print how to rebless Python formatting in tidy Suggested [here](rust-lang#134964 (comment)). r? ``@Noratrieb``
Run Python formatting check in tidy on CI I don't think that there's a reason why we should ignore Python formatting on CI, when we already check Python lints and C++ formatting. r? `@onur-ozkan`
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
Looks spurious, or at least definitely unrelated to this PR. @bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (372442f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary 12.6%, secondary 2.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 760.671s -> 762.936s (0.30%) |
Well, that was a particularly nasty walltime spike on |
I don't think that there's a reason why we should ignore Python formatting on CI, when we already check Python lints and C++ formatting.
r? @onur-ozkan