Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress host effect predicates if underlying trait doesn't hold #134951

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Suppress host effect predicates if underlying trait doesn't hold #134951

wants to merge 2 commits into from
+101 −19

Conversation

compiler-errors
Copy link
Member

Don't report two errors for when the (HostEffectPredicate) T: const Trait isn't implemented because (TraitPredicate) T: Trait doesn't even hold.

@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2024

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidtwco davidtwco

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@compiler-errors @rustbot @davidtwco