setup typos check in CI #134006
setup typos check in CI #134006
Conversation
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in exhaustiveness checking cc @Nadrieril Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval Some changes occurred in match checking cc @Nadrieril This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
This comment has been minimized.
This comment has been minimized.
klensy
force-pushed
the
typos
branch
2 times, most recently
from
f01ec3c to
5b7daa7
Compare
This comment has been minimized.
This comment has been minimized.
|
The Miri subtree was changed cc @rust-lang/miri |
| @@ -795,7 +795,7 @@ impl<'a> Parser<'a> { | |||
| // When there are a few keywords in the last ten elements of `self.expected_tokens` and the current | |||
| // token is an identifier, it's probably a misspelled keyword. | |||
| // This handles code like `async Move {}`, misspelled `if` in match guard, misspelled `else` in `if`-`else` | |||
| // and mispelled `where` in a where clause. | |||
| // and misspelled `where` in a where clause. | |||
There was a problem hiding this comment.
they misspelled "misspelled" 😀
|
I seem to recall a previous attempt at having typo-checks in CI that had a ton of false positives, this is much nicer, thanks. I can't approve the CI addition myself (does this require an FCP maybe?), but I looked through the typo fixes and they all look good to me. |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
A-meta
maybe an MCP? |
| # Add exclusions here, lines should be like `x = "x"`, where `x` is excluded word. | ||
| # | ||
| # Also see docs: https://github.com/crate-ci/typos/blob/v1.28.2/docs/reference.md |
There was a problem hiding this comment.
Based on the documentation these aren't exclusions, they're custom additions to the dictionary.
There was a problem hiding this comment.
Yes, but it is one of the ways to silence linter, so i wrote as exclusions, to simplify wording.
rustbot
added
O-unix
|
Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @rust-lang/wg-const-eval Some changes occurred to the platform-builtins intrinsics. Make sure the cc @antoyo, @GuillaumeGomez, @bjorn3, @calebzulawski, @programmerjake |
|
At time of MCP I had an idea, but reality of github CI action implementation prevented some nicer part of it, so i will revert to simple implementation and will resolve review comments. |
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
|
Oops, weird rebase. |
| @@ -4484,7 +4484,7 @@ declare_lint! { | |||
| /// | |||
| /// `refining_impl_trait` is a lint group composed of two lints: | |||
| /// | |||
| /// * `refining_impl_trait_reachable`, for refinements that are publically | |||
| /// * `refining_impl_trait_reachable`, for refinements that are publicly | |||
There was a problem hiding this comment.
doesn't need changing; likewise the one just below
|
☔ The latest upstream changes (presumably #133793) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Resolved more reviews and added new typo fixes. |
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
This allows to check typos in CI, currently for compiler only (to reduce commit size with fixes). With current setup, exclude list is quite short, so it worth trying?
Also includes commits with actual typo fixes.
MCP: rust-lang/compiler-team#817
typos check currently turned for:
After merging, PRs which enables checks for other crates (tools) can be implemented too.
Found typos will not break other jobs immediately: (tests, building compiler for perf run). Job will be marked as red on completion in ~ 20 secs, so you will not forget to fix it whenever you want, before merging pr.
Current fail in this pr is expected and shows how typo errors emitted. Commit with error will be removed after r+.