Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize the 2024 edition #133349

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Stabilize the 2024 edition #133349

merged 1 commit into from
Nov 23, 2024

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 22, 2024

This stabilizes the 2024 edition for Rust 1.85, scheduled to be released on February 20, 2025. 🎉

cc tracking issue: #117258

There is a fair amount of follow-up work after this that I am working on (various docs, cargo, rustfmt, etc.), and this is will unblock those other changes.

@rustbot
Copy link
Collaborator

rustbot commented Nov 22, 2024

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 22, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 22, 2024

Some changes occurred in tests/ui/sanitizer

cc @rust-lang/project-exploit-mitigations, @rcvalle

@traviscross traviscross added the A-edition-2024 Area: The 2024 edition label Nov 22, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Nov 22, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 22, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@traviscross
Copy link
Contributor

traviscross commented Nov 22, 2024 •
edited
Loading

On the edition team, we couldn't be more pleased with how things have worked out. Huge thanks to all item owners, reviewers, and to @ehuss for his invaluable work.

It's time to put the edition on the train for release.

@bors r=traviscross,compiler-errors p=10

@bors
Copy link
Contributor

bors commented Nov 22, 2024

📌 Commit 31c9222 has been approved by traviscross,compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2024
@bors
Copy link
Contributor

bors commented Nov 22, 2024

⌛ Testing commit 31c9222 with merge f5be3ca...

@bors
Copy link
Contributor

bors commented Nov 23, 2024

☀️ Test successful - checks-actions
Approved by: traviscross,compiler-errors
Pushing f5be3ca to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 23, 2024
@bors bors merged commit f5be3ca into rust-lang:master Nov 23, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Nov 23, 2024
This was referenced Nov 23, 2024
Merged
Open
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f5be3ca): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.2% [3.2%, 3.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 796.567s -> 794.975s (-0.20%)
Artifact size: 336.13 MiB -> 336.16 MiB (0.01%)

@traviscross traviscross added relnotes Marks issues that should be documented in the release notes of the next release. and removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 23, 2024
@rustbot rustbot mentioned this pull request Nov 23, 2024
Open
3 tasks
@nikomatsakis nikomatsakis mentioned this pull request Nov 27, 2024
Open
@aschaeffer aschaeffer mentioned this pull request Nov 27, 2024
Open
9 tasks
@ehuss ehuss mentioned this pull request Nov 28, 2024
Merged
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 28, 2024
@jhpratt
Rollup merge of rust-lang#133584 - ehuss:more-2024-unstable-options, …
eb9a3d2 
…r=compiler-errors

Update more 2024 tests to remove -Zunstable-options

This removes `-Zunsable-options` from more tests that I missed in rust-lang#133349.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 29, 2024
@matthiaskrgr
Rollup merge of rust-lang#133584 - ehuss:more-2024-unstable-options, …
53bc38b 
…r=compiler-errors

Update more 2024 tests to remove -Zunstable-options

This removes `-Zunsable-options` from more tests that I missed in rust-lang#133349.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2024
@rust-timer
Unrolled build for rust-lang#133584
48ba89a 
Rollup merge of rust-lang#133584 - ehuss:more-2024-unstable-options, r=compiler-errors

Update more 2024 tests to remove -Zunstable-options

This removes `-Zunsable-options` from more tests that I missed in rust-lang#133349.
This was referenced Dec 2, 2024
Open
Open
@shepmaster shepmaster mentioned this pull request Dec 2, 2024
Open
@ehuss ehuss mentioned this pull request Dec 11, 2024
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 11, 2024
@GuillaumeGomez
Rollup merge of rust-lang#134178 - ehuss:stabilize-2024-prelude, r=am…
01a01f1 
…anieu,traviscross,tgross35

Stabilize the Rust 2024 prelude

This stabilizes the `core::prelude::rust_2024` and `std::prelude::rust_2024` modules. I missed these in the rust-lang#133349 stabilization.
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 12, 2024
@jieyouxu
Rollup merge of rust-lang#134178 - ehuss:stabilize-2024-prelude, r=am…
3025feb 
…anieu,traviscross,tgross35

Stabilize the Rust 2024 prelude

This stabilizes the `core::prelude::rust_2024` and `std::prelude::rust_2024` modules. I missed these in the rust-lang#133349 stabilization.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 12, 2024
@matthiaskrgr
Rollup merge of rust-lang#134178 - ehuss:stabilize-2024-prelude, r=am…
90f6b27 
…anieu,traviscross,tgross35

Stabilize the Rust 2024 prelude

This stabilizes the `core::prelude::rust_2024` and `std::prelude::rust_2024` modules. I missed these in the rust-lang#133349 stabilization.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 12, 2024
@rust-timer
Unrolled build for rust-lang#134178
7091522 
Rollup merge of rust-lang#134178 - ehuss:stabilize-2024-prelude, r=amanieu,traviscross,tgross35

Stabilize the Rust 2024 prelude

This stabilizes the `core::prelude::rust_2024` and `std::prelude::rust_2024` modules. I missed these in the rust-lang#133349 stabilization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@traviscross traviscross

Labels
A-edition-2024 Area: The 2024 edition A-run-make Area: port run-make Makefiles to rmake.rs merged-by-bors This PR was explicitly merged by bors. PG-exploit-mitigations Project group: Exploit mitigations relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
8 participants
@ehuss @rustbot @rust-log-analyzer @traviscross @bors @rust-timer @compiler-errors @chenyukang